Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSK-1007: Add comments in talent editor #2922

Merged
merged 1 commit into from
Apr 7, 2023
Merged

TSK-1007: Add comments in talent editor #2922

merged 1 commit into from
Apr 7, 2023

Conversation

haiodo
Copy link
Member

@haiodo haiodo commented Apr 7, 2023

Fix placement for some Card based dialogs.

Contribution checklist

https://front.hc.engineering/workbench/platform/tracker/TSK-1007

image

Vacancy card with status if not group by status.

Screenshot 2023-04-07 at 23 31 34

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@haiodo
TSK-1007: Add comments in talent editor
ef637aa 
Fix placement for some Card based dialogs.

Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
@haiodo haiodo requested a review from BykhovDenis April 7, 2023 16:32
@haiodo haiodo merged commit 650e65a into main Apr 7, 2023
@haiodo haiodo deleted the TSK-1007 branch April 7, 2023 16:59
mrsadman99 pushed a commit that referenced this pull request Apr 10, 2023
Merge branch 'main' into TSK-1040
3f3d114 
* main: (28 commits)
  Bump and publish bitrix package (#2926)
  TSK-1088: Show Kanban counters (#2924)
  Fix activity is new (#2923)
  TSK-1007: Add comments in talent editor (#2922)
  TSK-1062: Fix merge properly (#2919)
  Replace "you and" (#2921)
  Fix bitrix gmail sync (#2918)
  TSK-997 В Activity Feed таланта писать событие об отправленном письме (#2917)
  TSK-1065: Check model version (#2916)
  TSK-1069. Displaying a Mention, as well as a Comment. Fixed MessageViewer. (#2915)
  TSK-1051 TSK-1052 TSK-1061 Inbox actions (#2914)
  Add commentator to collaborators (#2911)
  Tsk-1040: Support draft for DraggableList (#2898)
  TSK-1015: Bitrix Create Vacancy/Application (#2913)
  Add ignore keys for ClassFilters (#2912)
  Remove contact resolver id check (#2910)
  Add inbox employee bold (#2909)
  Fix notification mark (#2908)
  Inbox attriubute bar (#2907)
  Inbox title overflow fix (#2906)
  ...

Signed-off-by: Anton Brechka <anton.brechka@ezthera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BykhovDenis BykhovDenis BykhovDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haiodo @BykhovDenis